core.git: 3 commits - sal/osl sw/source

[Caolán McNamara (via logerrit)]

 sal/osl/unx/pipe.cxx          |    3 +++
 sw/source/filter/md/mdtab.cxx |    3 +--
 sw/source/ui/fldui/fldref.cxx |    3 +--
 3 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 2804283fdf39fefc2f51702a101af854e1cf4bbb
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 13 16:12:56 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 14 09:47:21 2025 +0200

    cid#1659046 COPY_INSTEAD_OF_MOVE
    
    Change-Id: I27b4cdaba8f162f710d6987501f389ed1ba0194f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187806
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/sw/source/filter/md/mdtab.cxx b/sw/source/filter/md/mdtab.cxx
index 351f30a911c8..ffdd37ceb976 100644
--- a/sw/source/filter/md/mdtab.cxx
+++ b/sw/source/filter/md/mdtab.cxx
@@ -69,8 +69,7 @@ void SwMarkdownParser::StartTable(sal_Int32 nRow, sal_Int32 
nCol)
     else
         AddParSpace();
 
-    std::shared_ptr<MDTable> xTable = std::make_shared<MDTable>(this);
-    m_xTable = xTable;
+    m_xTable = std::make_shared<MDTable>(this);
 
     const SwTable* pTable
         = m_xDoc->InsertTable(SwInsertTableOptions(SwInsertTableFlags::All, 
1), *m_pPam->GetPoint(),
commit ff727fdc201f8768eb631536beda2b073b0ce058
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 13 16:10:45 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 14 09:47:14 2025 +0200

    cid#1659044 Resource leak
    
    Change-Id: I6653e0cacb45239638fe086c9767493cf29aa3d1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187804
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/sal/osl/unx/pipe.cxx b/sal/osl/unx/pipe.cxx
index daeb0e65572c..3e1df1e23a87 100644
--- a/sal/osl/unx/pipe.cxx
+++ b/sal/osl/unx/pipe.cxx
@@ -208,7 +208,10 @@ static oslPipe osl_psz_createPipe(const char *pszPipeName, 
oslPipeOptions Option
     SAL_INFO("sal.osl.pipe", "new pipe on fd " << pPipe->m_Socket << " '" << 
name << "'");
 
     if (isForbidden(name, osl_File_OpenFlag_Create))
+    {
+        destroyPipeImpl(pPipe);
         return nullptr;
+    }
 
     addr.sun_family = AF_UNIX;
     // coverity[fixed_size_dest : FALSE] - safe, see check above
commit fc2b3aa23948fbf841b2928096aca33c926ea491
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 13 16:07:39 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 14 09:47:07 2025 +0200

    cid#1659053 Unchecked dynamic_cast
    
    Change-Id: Ifa46f0d628007645d8db4cbecbb57c6b30f21d23
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187803
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
index 7a9555d68495..10aed0092fe9 100644
--- a/sw/source/ui/fldui/fldref.cxx
+++ b/sw/source/ui/fldui/fldref.cxx
@@ -322,13 +322,12 @@ IMPL_LINK_NOARG(SwFieldRefPage, TypeHdl, weld::TreeView&, 
void)
 
     if(GetTypeSel() == -1)
     {
-        if (IsFieldEdit())
+        if (SwGetRefField* pRefField = IsFieldEdit() ? 
dynamic_cast<SwGetRefField*>(GetCurField()) : nullptr)
         {
             // select positions
             OUString sName;
             sal_uInt16 nFlag = 0;
 
-            SwGetRefField* pRefField = 
dynamic_cast<SwGetRefField*>(GetCurField());
             switch( pRefField->GetSubType() )
             {
                 case ReferencesSubtype::Bookmark: