sd/source/ui/func/futext.cxx | 14 --------------
1 file changed, 14 deletions(-)
New commits:
commit 9b4dac8bf180f3fd5441b447a60439fb258854d4
Author: Armin Le Grand (allotropia) <armin.le.grand.ext...@allotropia.de>
AuthorDate: Wed Feb 19 15:38:14 2025 +0100
Commit: Thorsten Behrens <thorsten.behr...@allotropia.de>
CommitDate: Sun Mar 2 19:34:50 2025 +0100
Avoid short blinking of text when activating TextEdit
In Presentation with title/Body with text directly activating
one by clicking makes the other 'blink' briefly when it gets
deactivated. All that has to do with OverlayManager, repaints
and the text being 'hidden' (to not be shown twice during
edit). That needs to be synchronized since OM refreshes using
a timer and direct paint to the target, while repaint uses
system's invalidate-and-paint-callback functionality. It
has shown that the immediate flush of the OM that was used
before is not needed anymore, so I removed that.
Note that there is task tdf#102293 mentioned as reason for
the flush, so I checked that the there mentioned triple/
double-click on text does the right thing.
Change-Id: Id9539129c5d6989959974befd15300abdfef3186
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181904
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behr...@allotropia.de>
diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index e434b4c68cbd..7c86fd6469e6 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -40,7 +40,6 @@
#include <editeng/editeng.hxx>
#include <svx/svdoutl.hxx>
#include <svx/svxids.hrc>
-#include <svx/sdr/overlay/overlaymanager.hxx>
#include <sfx2/docfile.hxx>
#include <editeng/outlobj.hxx>
#include <osl/diagnose.h>
@@ -1053,19 +1052,6 @@ void FuText::SetInEditMode(const MouseEvent& rMEvt, bool
bQuickDrag)
if (mpView->SdrBeginTextEdit(pTextObj.get(), pPV,
mpWindow, true, pOutl.release()) && mxTextObj.get()->GetObjInventor() ==
SdrInventor::Default)
{
- //tdf#102293 flush overlay before going on to pass
clicks down to
- //the outline view which will want to paint selections
- for (sal_uInt32 b = 0; b < pPV->PageWindowCount(); ++b)
- {
- const SdrPageWindow& rPageWindow =
*pPV->GetPageWindow(b);
- if (!rPageWindow.GetPaintWindow().OutputToWindow())
- continue;
- const rtl::Reference< sdr::overlay::OverlayManager
>& xManager = rPageWindow.GetOverlayManager();
- if (!xManager.is())
- continue;
- xManager->flush();
- }
-
bFirstObjCreated = true;
DeleteDefaultText();
