core.git: 2 commits - cui/source forms/source

[Caolán McNamara (via logerrit)]

 cui/source/tabpages/tpbitmap.cxx                 |    1 +
 forms/source/component/FormattedFieldWrapper.cxx |    5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 381c2ddf463cf126fd7693173542be43d2de923d
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Mar 1 12:04:53 2025 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sat Mar 1 20:06:55 2025 +0100

    cid#1643905 Uninitialized pointer field
    
    Change-Id: I8ec78ac3c713dd206846214c7a7309dfd5923b21
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182386
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/cui/source/tabpages/tpbitmap.cxx b/cui/source/tabpages/tpbitmap.cxx
index c257cbf2406b..820b73a7e66d 100644
--- a/cui/source/tabpages/tpbitmap.cxx
+++ b/cui/source/tabpages/tpbitmap.cxx
@@ -610,6 +610,7 @@ IMPL_LINK_NOARG(SvxBitmapTabPage, ClickDeleteHdl, 
SvxPresetListBox*, void)
 
 
SvxBitmapTabPage::SvxPresetListBoxValueSet::SvxPresetListBoxValueSet(std::unique_ptr<weld::ScrolledWindow>
 pWindow)
     : SvxPresetListBox(std::move(pWindow))
+    , m_pSvxBitmapTabPage(nullptr)
 {
 }
 
commit 180458bcc4b78bf964d11e8c7be1e6e175cc9262
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Mar 1 12:03:47 2025 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sat Mar 1 20:06:46 2025 +0100

    cid#1643904 COPY_INSTEAD_OF_MOVE
    
    Change-Id: I5f59d7f3f147aa80d164fd8d20e1adad317910d1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182385
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/forms/source/component/FormattedFieldWrapper.cxx 
b/forms/source/component/FormattedFieldWrapper.cxx
index 087612530bc7..a73f60d596b6 100644
--- a/forms/source/component/FormattedFieldWrapper.cxx
+++ b/forms/source/component/FormattedFieldWrapper.cxx
@@ -89,11 +89,10 @@ Reference< XCloneable > SAL_CALL 
OFormattedFieldWrapper::createClone()
     // clone the aggregate
     if ( m_xAggregate.is() )
     {
-        rtl::Reference< OEditBaseModel > xClone = 
static_cast<OEditBaseModel*>(m_xAggregate->createClone().get());
-        xRef->m_xAggregate = xClone;
+        
xRef->m_xAggregate.set(static_cast<OEditBaseModel*>(m_xAggregate->createClone().get()));
         OSL_ENSURE(xRef->m_xAggregate.is(), "invalid aggregate cloned !");
 
-        xRef->m_xFormattedPart = xClone;
+        xRef->m_xFormattedPart = xRef->m_xAggregate;
 
         if ( m_pEditPart.is() )
         {