svx/source/svdraw/svdedxv.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commits: commit 0b9573b77f785d857be2b5d20fb8e5d20beeca3d Author: Caolán McNamara <caolan.mcnam...@collabora.com> AuthorDate: Thu Dec 12 12:13:49 2024 +0000 Commit: Caolán McNamara <caolan.mcnam...@collabora.com> CommitDate: Fri Dec 13 09:56:17 2024 +0100 Hold vcl::Window by VclPtr suspicious that there is "delete pOLV" after retrieving a bare pointer, holdinf this by VclPtr looks sensible in any case. program/libmergedlo.so OutputDevice::LogicToPixel(tools::Rectangle const&) const /home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/source/outdev/map.cxx:906 program/libmergedlo.so vcl::Window::LogicToPixel(tools::Rectangle const&, MapMode const&) const /home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/source/window/window3.cxx:158 program/libmergedlo.so SdrObjEditView::SdrEndTextEdit(bool) /home/collabora/online-buildscripts/staging/builddir/libreoffice/svx/source/svdraw/svdedxv.cxx:1796 program/../program/libsdlo.so sd::View::SdrEndTextEdit(bool) /home/collabora/online-buildscripts/staging/builddir/libreoffice/sd/source/ui/view/sdview.cxx:780 program/../program/libsdlo.so sd::FuText::MouseButtonDown(MouseEvent const&) /home/collabora/online-buildscripts/staging/builddir/libreoffice/sd/source/ui/func/futext.cxx:290 Change-Id: Ic9e8c8cf4256acfcb45daa4b9d72b0cb1cea635a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178359 Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com> Tested-by: Jenkins diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx index 3e2af6ba81b8..374c38baf00e 100644 --- a/svx/source/svdraw/svdedxv.cxx +++ b/svx/source/svdraw/svdedxv.cxx @@ -1870,7 +1870,7 @@ SdrEndTextEditKind SdrObjEditView::SdrEndTextEdit(bool bDontDeleteReally) i--; OutlinerView* pOLV = pTEOutliner->GetView(i); sal_uInt16 nMorePix = pOLV->GetInvalidateMore() + 10; - vcl::Window* pWin = pOLV->GetWindow(); + VclPtr<vcl::Window> pWin = pOLV->GetWindow(); tools::Rectangle aRect(pOLV->GetOutputArea()); pTEOutliner->RemoveView(i); if (!mbTextEditDontDelete || i != 0)