core.git: svx/source

[Xisco Fauli (via logerrit)]

 svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx |    2 +-
 svx/source/sdr/primitive2d/sdrrectangleprimitive2d.cxx   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1329b4fa5428c00ccbb201dc3a08880b0ed09573
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Fri Nov 22 11:50:44 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Fri Nov 22 13:22:54 2024 +0100

    PVS: V560 A part of conditional expression is always true
    
    !aTempContentText.empty().
    
    Change-Id: If61fc09e7e19786ee055b78442b69f0147c8da75
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176998
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx 
b/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx
index 88cc3cf9bc61..7c697103c0bb 100644
--- a/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx
+++ b/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx
@@ -67,7 +67,7 @@ namespace drawinglayer::primitive2d
                         getWordWrap()));
 
                 // put text glow before, shape glow and shadow
-                if (!aTempContentText.empty() && 
!getSdrSTAttribute().getGlowText().isDefault())
+                if (!getSdrSTAttribute().getGlowText().isDefault())
                 {
                     // add text glow
                     aTempContentText = 
createEmbeddedTextGlowPrimitive(std::move(aTempContentText), 
getSdrSTAttribute().getGlowText());
diff --git a/svx/source/sdr/primitive2d/sdrrectangleprimitive2d.cxx 
b/svx/source/sdr/primitive2d/sdrrectangleprimitive2d.cxx
index cdfd75a88b98..e66285e6bb6e 100644
--- a/svx/source/sdr/primitive2d/sdrrectangleprimitive2d.cxx
+++ b/svx/source/sdr/primitive2d/sdrrectangleprimitive2d.cxx
@@ -103,7 +103,7 @@ namespace drawinglayer::primitive2d
                         false));
 
                 // put text glow before, shape glow and shadow
-                if (!aTempContentText.empty() && 
!getSdrLFSTAttribute().getGlowText().isDefault())
+                if (!getSdrLFSTAttribute().getGlowText().isDefault())
                 {
                     // add text glow
                     aTempContentText = 
createEmbeddedTextGlowPrimitive(std::move(aTempContentText), 
getSdrLFSTAttribute().getGlowText());