oox/source/export/DMLPresetShapeExport.cxx |   10 ----------
 1 file changed, 10 deletions(-)

New commits:
commit 6923fa7a92bd8f33b46be5e5ef6ff44362de435a
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Wed Nov 13 16:02:35 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Wed Nov 13 20:11:37 2024 +0100

    tdf#163486: PVS: identical conditional expressions
    
    Since
    commit 63cd67e5e18f01aca303131e148c80398a181a41
    Author: Attila Bakos (NISZ) <bakos.attilakar...@nisz.hu>
    Date:   Fri May 14 13:53:32 2021 +0200
    
        tdf#92525 tdf#142398: fix export of simple custom shapes
    
    V649    There are two 'if' statements with identical conditional 
expressions. The first 'if' statement contains function return. This means that 
the second 'if' statement is senseless. Check lines: 733, 738.
    
    Change-Id: I92bff7ef8472c1774e6def78c5f1a165ea6a0153
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176550
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
    Tested-by: Jenkins

diff --git a/oox/source/export/DMLPresetShapeExport.cxx 
b/oox/source/export/DMLPresetShapeExport.cxx
index c77cbd3fcd5b..3e383ac13d8b 100644
--- a/oox/source/export/DMLPresetShapeExport.cxx
+++ b/oox/source/export/DMLPresetShapeExport.cxx
@@ -735,11 +735,6 @@ bool DMLPresetShapeExporter::WriteShapeWithAVlist()
             // Does not have handle points, so preset enough.
             return false;
         }
-        if (sShapeType == "flowChartDecision")
-        {
-            // Does not have handle points, so preset enough.
-            return false;
-        }
         if (sShapeType == "flowChartDelay")
         {
             // Does not have handle points, so preset enough.
@@ -825,11 +820,6 @@ bool DMLPresetShapeExporter::WriteShapeWithAVlist()
             // Does not have handle points, so preset enough.
             return false;
         }
-        if (sShapeType == "flowChartDecision")
-        {
-            // Does not have handle points, so preset enough.
-            return false;
-        }
         if (sShapeType == "flowChartPredefinedProcess")
         {
             // Does not have handle points, so preset enough.

Reply via email to