oox/source/ppt/slidetransitioncontext.cxx |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

New commits:
commit 3c9715a64c6552f3b4e920a435fa1ad10489882b
Author:     Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Sun Oct 20 21:33:34 2024 +0200
Commit:     David Gilbert <freedesk...@treblig.org>
CommitDate: Sun Oct 27 01:21:56 2024 +0200

    tdf#163486: PVS: Identical branches
    
    V1037 Two or more case-branches perform the same actions. Check lines: 83, 
99
    
    Change-Id: Ibe913d3662bb7cb731dd55327c0df4182b328b69
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175272
    Reviewed-by: David Gilbert <freedesk...@treblig.org>
    Tested-by: Jenkins

diff --git a/oox/source/ppt/slidetransitioncontext.cxx 
b/oox/source/ppt/slidetransitioncontext.cxx
index e3e77cbeb6a9..a3ad670a676d 100644
--- a/oox/source/ppt/slidetransitioncontext.cxx
+++ b/oox/source/ppt/slidetransitioncontext.cxx
@@ -80,6 +80,8 @@ SlideTransitionContext::~SlideTransitionContext() noexcept
         return this;
     case PPT_TOKEN( cover ):
     case PPT_TOKEN( pull ):
+    case PPT_TOKEN( push ):
+    case PPT_TOKEN( wipe ):
         if (!mbHasTransition)
         {
             mbHasTransition = true;
@@ -94,14 +96,6 @@ SlideTransitionContext::~SlideTransitionContext() noexcept
             maTransition.setOoxTransitionType( aElementToken, 
sal_Int32(rAttribs.getBool( XML_thruBlk, false )), 0);
         }
         return this;
-    case PPT_TOKEN( push ):
-    case PPT_TOKEN( wipe ):
-        if (!mbHasTransition)
-        {
-            mbHasTransition = true;
-            maTransition.setOoxTransitionType( aElementToken, 
rAttribs.getToken( XML_dir, XML_l ), 0 );
-        }
-        return this;
     case PPT_TOKEN( split ):
         if (!mbHasTransition)
         {

Reply via email to