Hi,
As written in the previous mail, apparently, SCSTR_ALLFILTER is not used.
Therefore I removed SCSTR_ALLFILTER from sc/source/ui/view/gridwin.cxx,
where it is passed to a pFilterBox object, but has no effect.
To me it looks that SCSTR_ALLFILTER isn't used anywhere.
opengrok shows it in the soource file:
http://opengrok.libreoffice.org/xref/core/sc/source/ui/src/scstring.src#589
and in the define file:
http://opengrok.libreoffice.org/xref/core/sc/inc/sc.hrc#885
Remove it?
Regards,
--
- Cor
- http://nl.libreoffice.org
>From a2bcfbf565f9bae8b7335a68639e414690305340 Mon Sep 17 00:00:00 2001
From: Cor Nouws <oo...@nouenoff.nl>
Date: Sun, 10 Jun 2012 22:01:29 +0200
Subject: [PATCH 1/2] Remove unused argument
Change-Id: Id646516a71800fbc0fe82595b51f4468f12954d3
---
sc/source/ui/view/gridwin.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 40e8f38..12168f8 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -1228,7 +1228,7 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec
long nMaxText = 0;
// default entries
- static const sal_uInt16 nDefIDs[] = { SCSTR_ALLFILTER, SCSTR_TOP10FILTER, SCSTR_STDFILTER, SCSTR_FILTER_EMPTY, SCSTR_FILTER_NOTEMPTY };
+ static const sal_uInt16 nDefIDs[] = { SCSTR_TOP10FILTER, SCSTR_STDFILTER, SCSTR_FILTER_EMPTY, SCSTR_FILTER_NOTEMPTY };
const size_t nDefCount = SAL_N_ELEMENTS(nDefIDs);
for (i=0; i<nDefCount; i++)
{
--
1.7.9.5
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
