vcl/source/font/PhysicalFontFace.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 33ad73f3214d895f438d3e15c5099a4d878d5041
Author:     Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Tue Sep 6 07:52:10 2022 +0200
Commit:     Stephan Bergmann <sberg...@redhat.com>
CommitDate: Tue Sep 6 08:41:36 2022 +0200

    Missing initialization of PhysicalFontFace::mbFontCapabilitiesRead
    
    Regression introduced with 28c8cddd4218905bca05778dcdbae5911132a096 "vcl:
    Consolidate PhysicalFontFace::GetFontCapabilities()", causing
    
    > vcl/source/font/PhysicalFontFace.cxx:252:10: runtime error: load of value 
190, which is not a valid value for type 'bool'
    >  #0 in 
vcl::font::PhysicalFontFace::GetFontCapabilities(vcl::FontCapabilities&) const 
at vcl/source/font/PhysicalFontFace.cxx:252:10
    >  #1 in 
FreeTypeTextRenderImpl::GetFontCapabilities(vcl::FontCapabilities&) const at 
vcl/unx/generic/gdi/freetypetextrender.cxx:83:46
    >  #2 in SvpSalGraphics::GetFontCapabilities(vcl::FontCapabilities&) const 
at vcl/headless/svptext.cxx:46:30
    >  #3 in OutputDevice::GetFontCapabilities(vcl::FontCapabilities&) const at 
vcl/source/outdev/font.cxx:262:24
    >  #4 in makeShortRepresentativeTextForSelectedFont(OutputDevice const&) at 
svtools/source/misc/sampletext.cxx:1255:22
    >  #5 in DrawPreview(FontMetric const&, Point const&, OutputDevice&, bool) 
at svtools/source/control/ctrlbox.cxx:634:27
    >  #6 in FontNameBox::CachePreview(unsigned long, Point*) at 
svtools/source/control/ctrlbox.cxx:785:9
    >  #7 in FontNameBox::UpdateHdl(Timer*) at 
svtools/source/control/ctrlbox.cxx:564:5
    >  #8 in FontNameBox::LinkStubUpdateHdl(void*, Timer*) at 
svtools/source/control/ctrlbox.cxx:562:1
    >  #9 in Link<Timer*, void>::Call(Timer*) const at 
include/tools/link.hxx:111:45
    
    during CppunitTest_toolkit_a11y.
    
    Change-Id: I3591c4722410a8c6d1ae539f71a3d8ac37a4d3a3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139464
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/vcl/source/font/PhysicalFontFace.cxx 
b/vcl/source/font/PhysicalFontFace.cxx
index e20b9fce1405..5d90283fe1f4 100644
--- a/vcl/source/font/PhysicalFontFace.cxx
+++ b/vcl/source/font/PhysicalFontFace.cxx
@@ -38,6 +38,7 @@ namespace vcl::font
 PhysicalFontFace::PhysicalFontFace(const FontAttributes& rDFA)
     : FontAttributes(rDFA)
     , mpHbFace(nullptr)
+    , mbFontCapabilitiesRead(false)
 {
     // StarSymbol is a unicode font, but it still deserves the symbol flag
     if (!IsSymbolFont())

Reply via email to