[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/window/dialog.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5291c2a2238829bb6e1854dc24b6fc6662b8e5e2
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Mon Sep 5 09:14:35 2022 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Mon Sep 5 11:54:05 2022 +0200

    cid#1500642 silence Dereference before null check
    
    Change-Id: If72495279b7fedd2e825ca6944fc822d80ad5f2e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139405
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index 91f5a65b4054..fd6fb710c0af 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -1163,6 +1163,7 @@ void Dialog::EndDialog( tools::Long nResult )
     if ( mpDialogImpl->mbStartedModal )
         ImplEndExecuteModal();
 
+    // coverity[check_after_deref] - ImplEndExecuteModal might trigger 
destruction of mpDialogImpl
     if ( mpDialogImpl && mpDialogImpl->maEndCtx.isSet() )
     {
         auto fn = std::move(mpDialogImpl->maEndCtx.maEndDialogFn);