svx/source/svdraw/svdedxv.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 875aff18fb58767e909664fb81510a8853ad32c8
Author: Caolán McNamara <caol...@redhat.com>
AuthorDate: Mon Sep 5 17:18:09 2022 +0100
Commit: Caolán McNamara <caol...@redhat.com>
CommitDate: Mon Sep 5 22:09:38 2022 +0200
cid#1500657 silence Resource leak
it is pretty ugly stuff though
Change-Id: Icf588f44807d136342de6d5425bc41b968fff97f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139445
Tested-by: Caolán McNamara <caol...@redhat.com>
Reviewed-by: Caolán McNamara <caol...@redhat.com>
diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx
index 7915e4db5cb9..31e7ab5b9bdf 100644
--- a/svx/source/svdraw/svdedxv.cxx
+++ b/svx/source/svdraw/svdedxv.cxx
@@ -1500,12 +1500,11 @@ SdrEndTextEditKind SdrObjEditView::SdrEndTextEdit(bool
bDontDeleteReally)
mxWeakTextEditObj.clear();
mpTextEditPV = nullptr;
mpTextEditWin = nullptr;
- SdrOutliner* pTEOutliner = mpTextEditOutliner.release();
mpTextEditOutlinerView = nullptr;
pTextEditCursorBuffer = nullptr;
aTextEditArea = tools::Rectangle();
- if (pTEOutliner != nullptr)
+ if (SdrOutliner* pTEOutliner = mpTextEditOutliner.release())
{
bool bModified = pTEOutliner->IsModified();
if (pTEOutlinerView != nullptr)
@@ -1659,6 +1658,7 @@ SdrEndTextEditKind SdrObjEditView::SdrEndTextEdit(bool
bDontDeleteReally)
{
GetMarkedObjectListWriteAccess().SetNameDirty();
}
+ // coverity[leaked_storage] - if pTEOutliner wasn't deleted it didn't
really belong to us
}
if (pTEObj && !pTEObj->getSdrModelFromSdrObject().isLocked() &&
pTEObj->GetBroadcaster())
