[Libreoffice-commits] core.git: svx/source

[Caolán McNamara (via logerrit)]

 svx/source/svdraw/svdotxtr.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f137a42cc4979bf5bfcdcc23217f27f39556b41b
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Sat Sep 3 15:10:37 2022 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Sat Sep 3 16:52:13 2022 +0200

    crashtesting: fix use-after-free
    
    seen on exporting forum-mso-de-77310.pptx to ppt
    
    presumbly since:
    
    commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
    Date:   Thu May 27 10:27:46 2021 +0200
    
        ref-count SdrObject
    
    Change-Id: I883ecb8b39c95550673c51e086dcf3058588f9e8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139325
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/svx/source/svdraw/svdotxtr.cxx b/svx/source/svdraw/svdotxtr.cxx
index 95947be80425..17d4f8efc126 100644
--- a/svx/source/svdraw/svdotxtr.cxx
+++ b/svx/source/svdraw/svdotxtr.cxx
@@ -387,8 +387,8 @@ rtl::Reference<SdrObject> 
SdrTextObj::ImpConvertContainedTextToSdrPathObjs(bool
         }
         else if(1 == pObjectList->GetObjCount())
         {
-            pGroup.clear();
             pRetval = pObjectList->RemoveObject(0);
+            pGroup.clear();
         }
         else
         {