sw/source/ui/chrdlg/pardlg.cxx | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 9f7b3e2c47ff56c9529b3359e2459130ee922808
Author: Pranam Lashkari <lpra...@collabora.com>
AuthorDate: Wed Aug 3 00:20:43 2022 +0530
Commit: Pranam Lashkari <lpra...@collabora.com>
CommitDate: Wed Aug 3 17:46:27 2022 +0200
sw: always show "tabs" tab in the paragraph dialog for multiple paragraphs
In case multiple paragraphs were selected and the various paragraphs had
different left/right margins in their item sets, we used to hide the "tabs" tab
page on the paragraph dialog.
This had the benefit that we avoided presenting information that is not
entirely true for all paragraphs, but had the downside that it was not possible
to set tab stops for multiple paragraphs when at least one of the paragraph had
different left/right margins compared to the reset of the paragraphs. This
required the user to "hunt" for the offending paragraph(s). The ability to
always have the possibility to set tab stops seems to provide more benefit than
the cost of presenting a partially confusing "tabs" tab page when reading the
doc model.
Fix the problem by relaxing the requirements and only hiding the "tabs" tab
page in the writer/web page, show the tab page is now always shown for normal
documents.
This change makes no effort to show the common tab stops of all selected
paragraphs on the UI, which would probably make sense, but can be done in a
follow-up change.
Signed-off-by: Pranam Lashkari <lpra...@collabora.com>
Change-Id: Ida61e8878382988a7470d156ded187d21bcc9d91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137707
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
Reviewed-by: Miklos Vajna <vmik...@collabora.com>
(cherry picked from commit 3f97c911aa91c3bdfbae05fd5646b55987691e42)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137718
Tested-by: Jenkins
diff --git a/sw/source/ui/chrdlg/pardlg.cxx b/sw/source/ui/chrdlg/pardlg.cxx
index e465cb7e84f3..149833acc8c3 100644
--- a/sw/source/ui/chrdlg/pardlg.cxx
+++ b/sw/source/ui/chrdlg/pardlg.cxx
@@ -94,9 +94,7 @@ SwParaDlg::SwParaDlg(weld::Window *pParent,
else
RemoveTabPage("labelTP_PARA_ASIAN");
- const sal_uInt16 nWhich(rCoreSet.GetPool()->GetWhich(SID_ATTR_LRSPACE));
- bool bLRValid = SfxItemState::DEFAULT <= rCoreSet.GetItemState(nWhich);
- if(bHtmlMode || !bLRValid)
+ if(bHtmlMode)
RemoveTabPage("labelTP_TABULATOR");
else
{
