[Libreoffice-commits] core.git: svx/source

[Caolán McNamara (via logerrit)]

 svx/source/sidebar/shadow/ShadowPropertyPanel.cxx |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

New commits:
commit 83e1d079c4304ed43dfe8f9c92490d1bd4963f4c
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Fri Mar 4 14:11:46 2022 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Fri Mar 4 17:49:01 2022 +0100

    cid#1500667 Explicit null dereferenced
    
    I can't see how destroyingthe widget is a good idea here
    
    Change-Id: Ie4b2dcf9136568b01b5f4b85bcc849ad1c0504a9
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130992
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx 
b/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx
index ff21110a2007..93259adc27f0 100644
--- a/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx
+++ b/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx
@@ -271,15 +271,10 @@ void ShadowPropertyPanel::NotifyItemUpdate(
             if(eState >= SfxItemState::DEFAULT)
             {
                 const SdrOnOffItem* pItem = dynamic_cast< const SdrOnOffItem* 
>(pState);
-                if(pItem)
-                {
-                    if (pItem->GetValue())
-                        mxShowShadow->set_state(TRISTATE_TRUE);
-                    else
-                        mxShowShadow->set_state(TRISTATE_FALSE);
-                }
+                if (pItem && pItem->GetValue())
+                    mxShowShadow->set_state(TRISTATE_TRUE);
                 else
-                    mxShowShadow.reset();
+                    mxShowShadow->set_state(TRISTATE_FALSE);
             }
         }
         break;