svx/source/table/tablelayouter.cxx | 5 +++++
1 file changed, 5 insertions(+)
New commits:
commit c1b2ed31cbde0a81853ba4fe59841cded6c52105
Author: Justin Luth <justin_l...@sil.org>
AuthorDate: Tue Feb 8 09:04:47 2022 +0200
Commit: Justin Luth <jl...@mail.com>
CommitDate: Fri Mar 4 06:16:05 2022 +0100
related tdf#144092 svx: warn about wrong "empty cell" idea
An empty cell is not irrelevant in making height decisions,
at least in MS file formats, and yet all of this code that
is being based on that wrong assumption is being done to
import ppt(x) files, and causing one regression after another.
[Worst of all, this isn't even a filter import codebase.]
Unfortunately the regressions have been dealt with
or discovered slowly, so some of this has been in place
for years. Otherwise I would revert this in a heartbeat.
At least throw in a warning, so that this seemingly
logical conclusion will at least be challenged by
the next bug-fixer - instead of building another
layer on this house of cards.
Change-Id: I0e984a7ecce5061224a4165c0ee61818348a9659
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129659
Tested-by: Jenkins
Reviewed-by: Justin Luth <jl...@mail.com>
diff --git a/svx/source/table/tablelayouter.cxx
b/svx/source/table/tablelayouter.cxx
index 0c517707f4f8..87bd4436e7f3 100644
--- a/svx/source/table/tablelayouter.cxx
+++ b/svx/source/table/tablelayouter.cxx
@@ -766,6 +766,11 @@ void TableLayouter::LayoutTableHeight( tools::Rectangle&
rArea, bool bFit )
}
else
{
+ // WARNING: tdf#144092 / tdf#139511 suggest this entire
section is invalid.
+ // Empty cells should not be ignored in regards to row
height,
+ // especially MS formats, despite this code being added to
import MS files...
+ // The problem is getMinimumHeight can give wrong values
for empty cells.
+
bool bCellHasText = xCell->hasText();
bool bCellInEditMode = xCell->IsTextEditActive();
