chart2/source/controller/main/ControllerCommandDispatch.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 1af6ac544894fe9840716b0d4992852c16e73614
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Wed Feb 23 10:47:07 2022 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Wed Feb 23 14:56:00 2022 +0100

    cid#1500434 Dereference after null check
    
    Change-Id: I1a9531446fbd5f977d02775f5d25696aba16287d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130431
    Tested-by: Caolán McNamara <caol...@redhat.com>
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/chart2/source/controller/main/ControllerCommandDispatch.cxx 
b/chart2/source/controller/main/ControllerCommandDispatch.cxx
index d7406d3dbf60..33649bfd7a1f 100644
--- a/chart2/source/controller/main/ControllerCommandDispatch.cxx
+++ b/chart2/source/controller/main/ControllerCommandDispatch.cxx
@@ -562,12 +562,12 @@ void 
ControllerCommandDispatch::updateCommandAvailability()
 
     // toolbar commands
     m_aCommandAvailability[ ".uno:ToggleGridHorizontal" ] = bIsWritable;
-    m_aCommandArguments[ ".uno:ToggleGridHorizontal" ] <<= 
m_apModelState->bHasMainYGrid;
+    m_aCommandArguments[ ".uno:ToggleGridHorizontal" ] <<= bModelStateIsValid 
&& m_apModelState->bHasMainYGrid;
     m_aCommandAvailability[ ".uno:ToggleGridVertical" ] = bIsWritable;
-    m_aCommandArguments[ ".uno:ToggleGridVertical" ] <<= 
m_apModelState->bHasMainXGrid;
+    m_aCommandArguments[ ".uno:ToggleGridVertical" ] <<= bModelStateIsValid && 
m_apModelState->bHasMainXGrid;
 
     m_aCommandAvailability[ ".uno:ToggleLegend" ] = bIsWritable;
-    m_aCommandArguments[ ".uno:ToggleLegend" ] <<= m_apModelState->bHasLegend;
+    m_aCommandArguments[ ".uno:ToggleLegend" ] <<= bModelStateIsValid && 
m_apModelState->bHasLegend;
 
     m_aCommandAvailability[ ".uno:NewArrangement" ] = bIsWritable;
     m_aCommandAvailability[ ".uno:Update" ] = bIsWritable;

Reply via email to