[Libreoffice-commits] core.git: chart2/source

[Caolán McNamara (via logerrit)]

 chart2/source/tools/ConfigColorScheme.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit b2965afb8ba8ac155206a8dd790cd54ecfbf6d33
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Wed Feb 23 10:03:49 2022 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Wed Feb 23 12:15:37 2022 +0100

    cid#1500665 Dereference before null check
    
    Change-Id: I451c0faad1060ff7e97ef24af61940f402e1b243
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130416
    Tested-by: Caolán McNamara <caol...@redhat.com>
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/chart2/source/tools/ConfigColorScheme.cxx 
b/chart2/source/tools/ConfigColorScheme.cxx
index 50d72a88207e..acb42fcfb729 100644
--- a/chart2/source/tools/ConfigColorScheme.cxx
+++ b/chart2/source/tools/ConfigColorScheme.cxx
@@ -124,9 +124,7 @@ void ConfigColorScheme::retrieveConfigColors()
             new impl::ChartConfigItem( *this ));
         m_apChartConfigItem->addPropertyNotification( aSeriesPropName );
     }
-    OSL_ASSERT(m_apChartConfigItem);
-    if (!m_apChartConfigItem)
-        return;
+    assert(m_apChartConfigItem && "this can only be set at this point");
 
     // retrieve colors
     uno::Any aValue(