[Libreoffice-commits] core.git: connectivity/source

[Julien Nabet (via logerrit)]

 connectivity/source/commontools/dbtools2.cxx |   20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

New commits:
commit d8538d7fd693a24c7698ac9dd5447134c0c0f210
Author:     Julien Nabet <serval2...@yahoo.fr>
AuthorDate: Tue Feb 8 18:46:38 2022 +0100
Commit:     Julien Nabet <serval2...@yahoo.fr>
CommitDate: Tue Feb 8 21:21:56 2022 +0100

    Drop some methods returning just a string and only used once
    
    Change-Id: Idccc6edea7dabc79135d49ffe69c1a13f2990b76
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129684
    Reviewed-by: Julien Nabet <serval2...@yahoo.fr>
    Tested-by: Jenkins

diff --git a/connectivity/source/commontools/dbtools2.cxx 
b/connectivity/source/commontools/dbtools2.cxx
index a04015754374..74d427d248a9 100644
--- a/connectivity/source/commontools/dbtools2.cxx
+++ b/connectivity/source/commontools/dbtools2.cxx
@@ -945,33 +945,19 @@ sal_Int32 DBTypeConversion::convertUnicodeStringToLength( 
const OUString& _rSour
 
     return nLen;
 }
-static OUString lcl_getReportEngines()
-{
-    return "org.openoffice.Office.DataAccess/ReportEngines";
-}
-
-static OUString lcl_getDefaultReportEngine()
-{
-    return "DefaultReportEngine";
-}
-
-static OUString lcl_getReportEngineNames()
-{
-    return "ReportEngineNames";
-}
 
 OUString getDefaultReportEngineServiceName(const Reference< XComponentContext 
>& _rxORB)
 {
     ::utl::OConfigurationTreeRoot aReportEngines = 
::utl::OConfigurationTreeRoot::createWithComponentContext(
-        _rxORB, lcl_getReportEngines(), -1, 
::utl::OConfigurationTreeRoot::CM_READONLY);
+        _rxORB, "org.openoffice.Office.DataAccess/ReportEngines", -1, 
::utl::OConfigurationTreeRoot::CM_READONLY);
 
     if ( aReportEngines.isValid() )
     {
         OUString sDefaultReportEngineName;
-        aReportEngines.getNodeValue(lcl_getDefaultReportEngine()) >>= 
sDefaultReportEngineName;
+        aReportEngines.getNodeValue("DefaultReportEngine") >>= 
sDefaultReportEngineName;
         if ( !sDefaultReportEngineName.isEmpty() )
         {
-            ::utl::OConfigurationNode aReportEngineNames = 
aReportEngines.openNode(lcl_getReportEngineNames());
+            ::utl::OConfigurationNode aReportEngineNames = 
aReportEngines.openNode("ReportEngineNames");
             if ( aReportEngineNames.isValid() )
             {
                 ::utl::OConfigurationNode aReportEngine = 
aReportEngineNames.openNode(sDefaultReportEngineName);