connectivity/source/drivers/mysqlc/mysqlc_views.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4fa33b05e8128ced16240b663c1d3a487afb3f1d
Author:     Julien Nabet <serval2...@yahoo.fr>
AuthorDate: Thu Jan 27 13:07:55 2022 +0100
Commit:     Julien Nabet <serval2...@yahoo.fr>
CommitDate: Thu Jan 27 13:10:38 2022 +0100

    Mysql/MariaDB: remove obsolete comment in views
    
    Obsolete after eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45
    Mysql/MariaDB: after creating a view then refresh, make it appear as a view
    For this, I took example on hsqldb part this time (instead of Firebird 
which is uncomplete).
    
    Also, deleting a brand new created table works now.
    
    Of course, there are still pb with schema containing special characters 
like "`"
    
    In fact, the description of the previous commit was wrong since renaming a 
view
    still shows the table icon instead of view icon.
    You must reopen the file so the icon is ok.
    
    Change-Id: I2d27107db672e02af74e34a692309844ac310004
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129035
    Tested-by: Julien Nabet <serval2...@yahoo.fr>
    Reviewed-by: Julien Nabet <serval2...@yahoo.fr>

diff --git a/connectivity/source/drivers/mysqlc/mysqlc_views.cxx 
b/connectivity/source/drivers/mysqlc/mysqlc_views.cxx
index f1b7eb3895be..c9bf0658652d 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_views.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_views.cxx
@@ -111,7 +111,6 @@ void connectivity::mysqlc::Views::createView(
         xStmt->execute(aSql);
         ::comphelper::disposeComponent(xStmt);
     }
-    //  TODO find a way to refresh view to make the new one appear right away
     connectivity::mysqlc::Tables* pTables = 
static_cast<connectivity::mysqlc::Tables*>(
         
static_cast<connectivity::mysqlc::Catalog&>(m_rParent).getPrivateTables());
     if (pTables)

Reply via email to