Hi August, great cleanup, and nicer error handling for sure - pushed as-is, one question though:
> --- a/dbaccess/source/filter/xml/xmlExport.cxx
> +++ b/dbaccess/source/filter/xml/xmlExport.cxx
> @@ -565,8 +565,8 @@ void ODBExport::exportConnectionData()
> {
> ::svt::OFileNotation aTransformer( sFileName );
> ::rtl::OUStringBuffer sURL( aTransformer.get(
> ::svt::OFileNotation::N_URL ) );
> - if ( sURL.charAt(sURL.getLength()-1) != '/' )
> - sURL.append(sal_Unicode('/'));
> + if (sURL[sURL.getLength() - 1] != '/')
> + sURL.append('/');
>
>
> AddAttribute(XML_NAMESPACE_XLINK,XML_HREF,GetRelativeReference(sURL.makeStringAndClear()));
> }
That one does not seem to check for sURL.getLength() being > 0
before - or is that ensured externally?
Cheers,
-- Thorsten
pgpAeAeV1DEeJ.pgp
Description: PGP signature
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
