Hello Kohei, Thanks for making the improvements.
> I haven't found a way to change the color of edit box either, so we can > leave that a future project for now. Setting the background color is what I have used for the warning label: "aFtWarn.SetControlBackground( Color( COL_YELLOW ) );" I suppose something simular can be used for the edit box, if you want that. Joost 2011/1/3 Kohei Yoshida <kyosh...@novell.com> > Hello Joost, > > On Tue, 2010-12-28 at 16:45 +0100, Joost Eekhoorn wrote: > > Hoi Kohei and all, > > > > I hope you enjoy the lovely weather. > > > > Hereby a patch to give a better user experience to the "Move/Copy > > sheet" dialog. > > > > The changes are: > > - Removed the "Rename"checkbox. > > The "New name" textfield is always available, when one sheet is > > selected. > > It is disabled, when multiple sheets are selected. > > - "OK", "Cancel" and "Help" buttons placed at the bottom of the > > dialog. > > - "Copy" checkbox replaced by "Copy" and "Move" option buttons. > > - Added 3 section headers: "Action", "Location" and "Name". > > - Placed the text "(Current document)" behind the name > > of the of the current document in the list "To document". > > - Display the yellow warning " ! This name is already used", when > > applicable. > > This all looks good. Once again, I've taken the liberty of making some > follow-up modifications after your patch. I basically did: > > * adjusted the dialog layout a bit to make it look more consistent & > make better use of available spaces if possible. With this, the list > box etc are little wider. > > * added three different warning messages for different causes: 1) name > already used, 2) name is empty, and 3) name has invalid characters. > > * disable the OK button when the new name is invalid. > > > I did not know a better way to display the warning (I searched several > > hours.) > > I think the way you did it is sufficient; but I'd like us to eventually > find a way to turn the background of the sheet name box pink (or light > red, whatever the actual color is) the same way the chart dialogs do > while the background color of the warning text stays transparent. IMO > that would fit a little better and more consistent with the rest of our > UI. > > I haven't found a way to change the color of edit box either, so we can > leave that a future project for now. > > > I did not changed the "Insert before" listbox. > > I think it's best if we leave this alone for now. We'll probably come > back to it later. > > > I do not display the current sheet name. > > I assume you mean displaying the current sheet name in the title bar of > the dialog box. Yeah we'll leave this a future project too. > > Thanks a lot for your patch. :-) > > Kohei > > -- > Kohei Yoshida, LibreOffice hacker, Calc > <kyosh...@novell.com> > >
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
