https://bugs.documentfoundation.org/show_bug.cgi?id=167511
Armin Le Grand (collabora) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |om --- Comment #20 from Armin Le Grand (collabora) <[email protected]> --- Luckily it seems as if DrawModeFlags::SettingsForSelection is only used in OverlayManager, and there specific for painting the selections. NOTE: That is done setting that flag at the target OutDev - guess when this will no longer be working... If e.g. another renderer like CairoSDPR is used. Thus all that is unfortunately a hack and will also need to be replaced/fixed. It only works with VCLPixelPrimitiveRenderer because there the set flags from OverlayManager::ImpDrawMembers will be used. What really needs to be done is not to patch Colors in the renderer like OutDev, but to use the correct colors where those controls are painted. I am sure having done it the way it is now was fast(er), but as we see this comes for a price - it has to be done correctly one day anyways - sigh... For fixing this task I will go with the direct way, is doable. @Testers: As said, there *should* be more errors due to that hacks used in OutputDevice, please have a look at TextSelections, these will probably use incorrect colors due to how it was done. Write bugs and inform me. -- You are receiving this mail because: You are the assignee for the bug.
