Hi, Silvio
You patch will turn on TCP_NODELAY globally upon request, but it should be used at specific moments as Martin Bonner pointed in http://lists.gnu.org/archive/html/libmicrohttpd/2015-11/msg00073.html
You also shift values in emun which will result in breaking ABI compatibility (programs compiled with older version of MHD will not work as expected with newer versions).
TCP_NODELAY is not configuration option, it's system value, so it shouldn't be defined in MHD_config.h (or as -D parameter) as in that case it will conflict with system value and confuse code about really available system options.
I will fix code based on your and Martin Bonner finding.
--
Best Wishes,
Evgeny Grin
20.11.2015, 06:44, "silvioprog" <[email protected]>:
Hello,About the `TCP NODELAY` feature, it reduces the network latency on many operating systems, and this patch allows MHD to disable it. Popular servers like nginx allows to enable the `TCP NODELAY` feature[1].You can see more details about this patch here in this topic[2].Feel free to change any part of this patch!Thank you!
