On Sat, May 27, 2023 at 03:32:36PM +0200, Jürgen Hötzel wrote: > Fixes failing implice_close test on OCaml 5. > --- > ocaml/t/guestfs_065_implicit_close.ml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ocaml/t/guestfs_065_implicit_close.ml > b/ocaml/t/guestfs_065_implicit_close.ml > index 567e550b4..5e00c21ac 100644 > --- a/ocaml/t/guestfs_065_implicit_close.ml > +++ b/ocaml/t/guestfs_065_implicit_close.ml > @@ -30,8 +30,8 @@ let () = > *) > > (* This should cause the GC to close the handle. *) > -let () = Gc.compact () > +let () = Gc.full_major ()
I pushed this hunk upstream, but not the second change below. That should be sufficient to fix it on OCaml 5 while maintaining the ability to compact the heap to check for integrity. See: https://github.com/libguestfs/libguestfs/commit/1274452d225da71f115e0cb8ad435e02670dc4fb > let () = assert (!close_invoked = 1) > > -let () = Gc.compact () > +let () = Gc.full_major () Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
