Matthew Burgess wrote:
> On 16/04/2010 07:03, Bruce Dubbs wrote:
>> I've been working with some new packages:
>>
>> GCC-4.5.0
>
> Note that this causes a test failure in Bison-2.4.2. It's already been
> reported at
> http://lists.gnu.org/archive/html/bug-bison/2010-03/msg00030.html with a
> patch attached to the reply there.
Good spot. That's in my logs too.
For the list, the patch is below. It amounts to a one line change, We
might want to consider a sed instead of a patch.
sed -i -e "s/\[cat stdout\]/[grep -v ': In function ' stdout]/" \
tests/synclines.at
-- Bruce
>From 2289d9f5152384dc35e0b555dba5eed1d44a2568 Mon Sep 17 00:00:00 2001
From: Joel E. Denny <addr...@hidden>
Date: Wed, 31 Mar 2010 12:46:53 -0400
Subject: [PATCH] portability: fix test suite for GCC 4.5's new #error
message.
Reported by Tys Lefering at
<http://lists.gnu.org/archive/html/bug-bison/2010-03/msg00030.html>.
* NEWS (2.4.3): Mention.
* tests/synclines.at (AT_TEST_SYNCLINE): Implement.
---
ChangeLog | 8 ++++++++
NEWS | 2 ++
tests/synclines.at | 4 +++-
3 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index f312421..49c221b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2010-03-31 Joel E. Denny <addr...@hidden>
+
+ portability: fix test suite for GCC 4.5's new #error message.
+ Reported by Tys Lefering at
+ <http://lists.gnu.org/archive/html/bug-bison/2010-03/msg00030.html>.
+ * NEWS (2.4.3): Mention.
+ * tests/synclines.at (AT_TEST_SYNCLINE): Implement.
+
2010-03-23 Joel E. Denny <addr...@hidden>
portability: fix for BSD make.
diff --git a/NEWS b/NEWS
index 31d7c79..4750963 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,8 @@ Bison News
** Problems with spawning M4 on at least FreeBSD 8 and FreeBSD 9 have
been fixed.
+** Failures in the test suite for GCC 4.5 have been fixed.
+
* Changes in version 2.4.2 (2010-03-20):
** Some portability problems that resulted in failures and livelocks
diff --git a/tests/synclines.at b/tests/synclines.at
index 08b33c5..a975433 100644
--- a/tests/synclines.at
+++ b/tests/synclines.at
@@ -71,7 +71,9 @@ AT_CHECK([[test "`cat stdout`" = 'syncline.c:1: @%:@error
"1"' || exit 77]])
AT_DATA([[input.y]], [$2])
AT_BISON_CHECK([-o input.c input.y])
AT_SYNCLINES_COMPILE([input.c])
-AT_CHECK([cat stdout], 0, [$3])
+# GCC 4.5 tells you the function within which #error appears, but
+# previous versions of gcc do not.
+AT_CHECK([grep -v ': In function ' stdout], 0, [$3])
AT_CLEANUP
])
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
