On 8/19/06, Joe Ciccone <[EMAIL PROTECTED]> wrote:
Moshe wrote: > Hi Joe, > > If you are testing the openat patch, > please do not forget to change > the __OPENAT () definition from K&R style: > > __OPENAT (fd, file, oflag) > int fd; > const char *file; > int oflag; > > to the variadic function: > > __OPENAT (int fd, const char *file, int oflag, ...) > > or you will not be able to compile the openat.c file. > This is the patch that has proved its self to work (on x86, x86_64, mips, and alpha). I see no reason to convert the function from K&R (whatever that is). That statement has nothing wrong with it. http://www.linuxfromscratch.org/patches/downloads/glibc/glibc-2.4-openat-3.patch
Drepper's checked something in to address the problem and closed the bug reports if anyone's interested. I haven't tested it. http://sourceware.org/bugzilla/show_bug.cgi?id=3040 http://sourceware.org/ml/glibc-cvs/2006-q3/msg00278.html http://sourceware.org/cgi-bin/cvsweb.cgi/libc/sysdeps/unix/sysv/linux/openat.c.diff?cvsroot=glibc&r1=1.8&r2=1.9 P.S. K&R refers to Kernighan and Ritchie who wrote C. In ~1988 when ANSI was standardized, some stuff changed changed like how functions are declared. In K&R, the function parameters (fd, *file, oflag above) are declared between the function declaration and the function block. -- Dan -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
