I have changed the patch to only change the version name. Ubiquiti is
currently at AirMAX firmware version 6.0.4. So version 6.0.0 for us is
IMHO a good/current version number.

I also checked if 0.0.0 would have worked. It resulted in an error on
the device I had.


txt.file
--
This message is signed.

Felix Fietkau:
> On 2017-05-02 10:18, txt.file wrote:
>> Felix Fietkau:
>>>> -          -B $(UBNT_BOARD) -v 
>>>> $(UBNT_TYPE).$(UBNT_CHIP).v6.0.0-OpenWrt-$(REVISION) \
>>>> +          -B $(UBNT_BOARD) -v 
>>>> $(UBNT_TYPE).$(UBNT_CHIP).v0.0.0-$(VERSION_DIST)-$(REVISION) \
>>> The Ubiquiti firmware web interface parses the version number, right?
>>> Did you do any tests to check how it reacts to the 0.0.0 version number?
>> Not yet. Is now on my TODO for this week.
>>
>> txt.file
> I thought about this some more. Even if it works, I'd prefer changing
> the version to match a recent AirOS version. The 0.0.0 just looks weird.
> Also, the version should probably be changed in a separate commit.
> 
> - Felix
> 

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Reply via email to