27.11.2016 06:28, J Mo:
diff --git a/target/linux/ipq806x/image/Makefile b/target/linux/ipq806x/image/Makefile index 3cc48bb..01bcbc7 100644 --- a/target/linux/ipq806x/image/Makefile +++ b/target/linux/ipq806x/image/Makefile @@ -103,6 +103,49 @@ define Device/ZyXELImage IMAGE/mmcblk0p4-kernel.bin := append-kernel endef+define Build/mkfit-TEW827DRU + $(TOPDIR)/scripts/its-maker.sh \ + --device $(DEVICE_NAME) \ + -O $@.its \ + --img-name 0 script \ + --img-descr 0 "u-boot-HTTP firmware update script" \ + --img-file 0 $(TOPDIR)/target/linux/ipq806x/image/tew827dru-flash.scr \ + --img-type 0 script --img-arch 0 $(ARCH) \ + --img-compression 0 none \ + --img-hashes 0 crc32 \ + --img-name 1 ubi-image \ + --img-descr 1 "UBI rootfs image" \ + --img-file 1 $@ \ + --img-type 1 firmware \ + --img-arch 1 $(ARCH) \ + --img-compression 1 none \ + --img-hashes 1 crc32 \ + --img-name 2 bootconfig \ + --img-descr 2 "BOOTCONFIG: boot from APPSBL and rootfs" \ + --img-file 2 $(TOPDIR)/target/linux/ipq806x/image/tew827dru-bootconfig.bin \ + --img-type 2 firmware \ + --img-arch 2 $(ARCH) \ + --img-compression 2 none \ + --img-hashes 2 crc32 + PATH=$(LINUX_DIR)/scripts/dtc:$(PATH) mkimage -f $@.its $@.fit + @rm $@.its + @mv $@.fit $@ +endef + +define Build/cameo-sig + { \ + cameo_sig=$(word 1, $(1)) ;\ + align=$(if $(2),$(2),64) ;\ + oldsize=$$(stat -c %s $@) ;\ + sigsize=$$(echo -n $$cameo_sig | wc -c) ;\ + padsize=$$(( ( ( ( ( ( $$oldsize + $$sigsize ) / $$align ) + 1 ) * $$align ) - $$oldsize ) - $$sigsize )) ;\ + newsize=$$(( $$oldsize + $$padsize )) ;\ + dd if=$@ of=$@.new bs=$$newsize count=1 conv=sync ;\ + echo -n "$$cameo_sig" >> $@.new ; \ + } + @mv $@.new $@ +endef
I asked you three (!) times to _explain_ what this code should do [0][1][2]. Now I see the very same code again without having ever seen the requested explanation.
This still looks like the hackish image code that was required with the old image build system. I guess most of the stuff can be done with the existing build helpers.
To say it with easy understandable words: This patch will not be merged till I get an understandable answer what this code should do. I do not even consider doing a review before I get this answer.
Mathias [0] http://lists.infradead.org/pipermail/lede-dev/2016-September/002677.html [1] http://lists.infradead.org/pipermail/lede-dev/2016-September/002681.html [2] http://lists.infradead.org/pipermail/lede-dev/2016-September/002744.html _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
