Hello Christian,
Small comments below, inline.
2016-10-04 22:55 GMT+02:00 Christian Lamparter <chunk...@googlemail.com>:
[snip]
> diff --git a/target/linux/ar71xx/base-files/etc/diag.sh
> b/target/linux/ar71xx/base-files/etc/diag.sh
> index d6e257d..5f2056e 100644
> --- a/target/linux/ar71xx/base-files/etc/diag.sh
> +++ b/target/linux/ar71xx/base-files/etc/diag.sh
> @@ -76,6 +76,9 @@ get_status_led() {
> c-55)
> status_led="$board:green:pwr"
> ;;
> + c-60)
> + status_led="c-60:green:pwr"
> + ;;
Please, use $board variable here and combine c-60 with c55 as both
boards use same LED name.
[snip]
> diff --git a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> index 559f97d..e89cc24 100755
> --- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> +++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> @@ -484,6 +484,7 @@ platform_check_image() {
>
> return 0
> ;;
> + c-60|\
> nbg6716|\
> r6100|\
> wndr3700v4|\
> @@ -540,6 +541,7 @@ platform_pre_upgrade() {
> z1)
> merakinand_do_upgrade "$1"
> ;;
> + c-60|\
> nbg6716|\
> r6100|\
> wndr3700v4|\
This breaks alphabetical order.
Boards are ordered in two steps: within every case block and then
whole case blocks are ordered, based on first board.
Please reorder case blocks here too.
[snip]
> diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-c60.c
> b/target/linux/ar71xx/files/arch/mips/ath79/mach-c60.c
> new file mode 100644
> index 0000000..26930a9
> --- /dev/null
> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-c60.c
[snip]
> +/* can be used to "lock" the console port */
> +#define C60_GPIO_LOCK_CONSOLE_PORT 9
I'm not sure why did you define it here as it's not used.
Plus, GPIO9 is by default configured as UART0 RX signal on AR934x.
[snip]
Thanks for your contribution!
Cheers,
Piotr
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
