-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6823/#review10470
-----------------------------------------------------------



/trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp
<http://svn.reviewboard.kde.org/r/6823/#comment12404>

    Ohh come on, just adding a "false && " is definitely not the the right way 
to fix this bug. You will have to soent a few minutes more if you want to fix  
it !
    
    If there is a valid nickname, then metaContact()->customDisplayName() != 
item.name() should be false, right ?
    
    
    


- Frank Schaefer


On Nov. 8, 2011, 7:55 p.m., Cyberbeat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6823/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 7:55 p.m.)
> 
> 
> Review request for Kopete.
> 
> 
> Description
> -------
> 
> This patch fixes the bug, that the jabber protocol overwrites manually given 
> nicknames each time kopete connects.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=274175.
>     
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=274175
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp 1263246 
> 
> Diff: http://svn.reviewboard.kde.org/r/6823/diff/diff
> 
> 
> Testing
> -------
> 
> I used kopete several weeks with icq, jabber, msn protocol together with my 
> patch, and did not notice any problems. The wrong behaviour is fixed.
> 
> 
> Thanks,
> 
> Cyberbeat
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to