> On Dec. 23, 2010, 11:19 a.m., Raphael Kubo da Costa wrote: > > Assuming Kopete doesn't keep binary compatibility between releases, this > > can go in (remember to backport to the 4.5 and 4.6 branches). If you prefer > > to go on the safe side, do as suggested and keep BC. > > Raphael Kubo da Costa wrote: > Oh, and please check if this closes any bug report. > > Raphael Kubo da Costa wrote: > Last but not least: if you make the method public, please add the > appropriate apidox to it.
Did added the missing apidox and applied the patch to trunk. Please close this review request. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/3260/#review9385 ----------------------------------------------------------- On March 12, 2010, 3:03 p.m., Teemu Rytilahti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/3260/ > ----------------------------------------------------------- > > (Updated March 12, 2010, 3:03 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > This patch modifies the behaviour of idle timer to not to confirm whether to > come back from auto-away when there are no accounts online. The problem > before was that I got spammed "Do you want to set yourself as available" when > coming back from away, even if the Kopete was not connected to any servers. > > As I am not familiar with the codebase, I hope someone can review and see > whether the approach I'm using here is ok. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccountmanager.h 1101310 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.h 1101310 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.cpp 1101310 > > Diff: http://svn.reviewboard.kde.org/r/3260/diff > > > Testing > ------- > > Tested by using the patched version for a while. Returning from auto-away > still works just fine when there are accounts connected, but you won't get > confirmation dialog when coming back when there is no online accounts. > > > Thanks, > > Teemu > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
