----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/3260/#review8240 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccountmanager.h <http://svn.reviewboard.kde.org/r/3260/#comment8500> I don't think you're allowed to make this one public. See http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_access_rights See here for a solution: http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B ("If you need to make a private function protected or even public, you have to add a new function that calls the private one.") - Martin On 2010-03-12 15:03:03, Teemu Rytilahti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/3260/ > ----------------------------------------------------------- > > (Updated 2010-03-12 15:03:03) > > > Review request for Kopete. > > > Summary > ------- > > This patch modifies the behaviour of idle timer to not to confirm whether to > come back from auto-away when there are no accounts online. The problem > before was that I got spammed "Do you want to set yourself as available" when > coming back from away, even if the Kopete was not connected to any servers. > > As I am not familiar with the codebase, I hope someone can review and see > whether the approach I'm using here is ok. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccountmanager.h 1101310 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.h 1101310 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.cpp 1101310 > > Diff: http://svn.reviewboard.kde.org/r/3260/diff > > > Testing > ------- > > Tested by using the patched version for a while. Returning from auto-away > still works just fine when there are accounts connected, but you won't get > confirmation dialog when coming back when there is no online accounts. > > > Thanks, > > Teemu > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
