Cristi P <cristi.pos...@gmail.com> writes: > Good catch with the yahoo thing (it is -DWITH_yahoo=off though). > Since you say you already edited locally to fix my tab problem (sorry, > didn't spend time checking my editors settings), just move the 3 lines re: > libjasper from kopete/CMakeLists.txt to > kopete/protocols/yahoo/CMakeLists.txt and things should be fine. > > Tested by running kdesrc-build --no-src --reconfigure kdenetwork > and kdesrc-build --no-src --reconfigure > --kdenetwork,cmake-options=-DWITH_yahoo=OFF kdenetwork > and checking cmake.log
Done and committed both to trunk and the 4.6 branch. One thing I forgot to mention is that I also removed some extra empty lines in the files modified by the commit and merged some of your CMake calls (such as target_link_libraries) with the existing ones. In the .cpp file you added, I also reordered the #includes: config-*.h should come before anything else, followed by cpp's-header-file.h. Can you please close the review request? Thanks for the patch! _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
