----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5364/ -----------------------------------------------------------
(Updated 2010-09-16 14:20:36.835752) Review request for Kopete. Changes ------- Added signal viewActivated to KopeteChatSession. Connected this signal to notification->close slot so this notification will close when view is activated (because user don't need these notifications anymore; this idea was taken from bug 244589) Summary ------- This patch makes user_is_typing notifications to use ActiveNotifications. I did it because kopete sometimes shows up to five different user_is_typing notifications for one user (as for me) simultaneously, and it really annoys me sometimes. With it, kopete will show only one this notification for an user in one time. It also adds an user_is_typing_message notification for oscar protocol even if there are no available chat session for current contact (for example, someone is typing a message to you first time) Diffs (updated) ----- /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h 1175782 /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1175782 /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.h 1175782 /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.cpp 1175782 /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp 1175782 Diff: http://svn.reviewboard.kde.org/r/5364/diff Testing ------- Patch applies to current trunk. Kopete compiles fine with it. If someone (oscar contact) starts typing you a message (if there are no available windows with this contact), it shows user_is_typing notification. If there is one visible user_is_typing notification, kopete doesn't show a new notification. So all works fine now (as for me, of course) Thanks, Igor
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
