> On 2010-09-16 00:53:56, Raphael Kubo da Costa wrote: > > Do you know if there are open bug reports about this one? I remember seeing > > people complaining about this on #kde-devel at least. > > > > The bulk of the changes is supposed to work for all protocols, with the > > OSCAR changes being independent from the rest, right?
Yep it should work with all protocols (supports typing message notifications, of course), but I tested only with oscar protocol. It should work with all protocols too, of course. I saw some bugs to user_is_typing messages (bug 249543, bug 244589). But looks like they are about notification plasmoid, which saves all these notifications in history (when we clicks on it). - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5364/#review7630 ----------------------------------------------------------- On 2010-09-15 22:40:58, Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5364/ > ----------------------------------------------------------- > > (Updated 2010-09-15 22:40:58) > > > Review request for Kopete. > > > Summary > ------- > > This patch makes user_is_typing notifications to use ActiveNotifications. I > did it because kopete sometimes shows up to five different user_is_typing > notifications for one user (as for me) simultaneously, and it really annoys > me sometimes. With it, kopete will show only one this notification for an > user in one time. > It also adds an user_is_typing_message notification for oscar protocol even > if there are no available chat session for current contact (for example, > someone is typing a message to you first time) > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1175782 > /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.h > 1175782 > /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.cpp > 1175782 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp 1175782 > > Diff: http://svn.reviewboard.kde.org/r/5364/diff > > > Testing > ------- > > Patch applies to current trunk. > Kopete compiles fine with it. > If someone (oscar contact) starts typing you a message (if there are no > available windows with this contact), it shows user_is_typing notification. > If there is one visible user_is_typing notification, kopete doesn't show a > new notification. > > So all works fine now (as for me, of course) > > > Thanks, > > Igor > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
