> On 2010-08-25 18:53:27, Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp, line 1162 > > <http://reviewboard.kde.org/r/5141/diff/2/?file=34547#file34547line1162> > > > > You made this notification account specific here, which conflicts with > > the global configuration in menu -> Configurations -> Configure > > Notifications -> Mail, I do not like this. In despite I do not use my yahoo > > mail account anymore, for users that have both hotmail and yahoo account > > they will need to configure notifications twice to make them work with both > > accounts. If you want to let users configure notifications per account > > basis you must honor the global configuration as default to prevent this > > conflict. That would also solve the other problem symptom I have found with > > your patch: my mail notification stopped working until I configured them in > > my wlm account because this line makes kopete ignores the > > [Event/kopete_mail] notification in > > $KDEDIR/share/apps/kopete/kopete.notifyrc. > > Igor Poboiko wrote: > Thanks for your reply. > I'm agree with it. I thought about it, but I thought that KNotify will > (or must) take care about it. But how is it done for notifications > per-metacontact/group? It doesn't look like we need to configure > notifications for every metacontact/group. Or do we? > And I don't see specific code for using global configuration there. Or is > it done wrong way there too? > > As far as I know, by default all context-specific events are unchecked. > How can we distinguish that from unchecked-by-user? In first case we should > show notification (if it is enabled in global configuration, of course; that > is what you want, as I understood) and in second case we shouldn't (just > because user unchecked it) > > Lamarque Souza wrote: > Hmmm it is working now, I think knotify took too much time to recognise > the modifications in kopete.notifyrc, the famous cache effect. In fact, > knotify takes care of contexts so there is no problem with this line in your > code. The user will have to logout and login again for this change to take > effect, maybe running kbuildsycoca4 can solve this little detail too.
So there is no problems with it? Nice. - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5141/#review7213 ----------------------------------------------------------- On 2010-08-25 16:53:20, Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5141/ > ----------------------------------------------------------- > > (Updated 2010-08-25 16:53:20) > > > Review request for Kopete. > > > Summary > ------- > > This patch adds an 'account' context and possibility to change following > notifications for account: > kopete_mail, connection_error[empty], connection_lost, server_error[empty], > network_problems[empty], buzz_nudge, cannot_connect. > ('[empty]' means that this notification doesn't use anywhere) > > It groups 'msn_mail' and 'yahoo_mail' to one event - 'kopete_mail'. > It changes 'icq_authorization' to 'kopete_authorization' (yahoo protocol used > this event, but actually it didn't exist) > It adds an 'Configure Notifications' button to Accounts KCM, which shows > dialog with ability to change notifications for current account. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/config/accounts/CMakeLists.txt 1167882 > /trunk/KDE/kdenetwork/kopete/kopete/config/accounts/kopeteaccountconfig.h > 1167882 > /trunk/KDE/kdenetwork/kopete/kopete/config/accounts/kopeteaccountconfig.cpp > 1167882 > > /trunk/KDE/kdenetwork/kopete/kopete/config/accounts/kopeteaccountconfigbase.ui > 1167882 > /trunk/KDE/kdenetwork/kopete/kopete/kopete.notifyrc 1167882 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1167882 > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteutils.cpp 1167882 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp 1167882 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 1167882 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahooaccount.cpp 1167882 > > Diff: http://reviewboard.kde.org/r/5141/diff > > > Testing > ------- > > Kopete from KDE 4.5.0 (and trunk) compiles fine with it. > 'Configure Notifications' button works, it shows the dialog and saves all the > data. > Actually, I can't test buzz_nudge, kopete_mail, connection_lost and > cannot_connect (because I don't have yahoo/wlm account, only where it used). > I'll try to create an yahoo account and make more testing (or can anyone who > have yahoo/wlm account test it?) > > > Thanks, > > Igor > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
