-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5159/
-----------------------------------------------------------

Review request for Kopete.


Summary
-------

When the config dialog is opened on a machine which features a webcam, it grows 
quite tall because the Video page adds sliders to control the image. The screen 
height of netbooks is often 600px or even 576px. The dialog does not fit in 
these screens as it gets around 640px tall.

Attached patch moves the sliders from below the video preview to the right 
reducing the height to 535px here. It causes the dialog to be a bit wide (939px 
here), but most machines should handle it and in the worse case it is easier to 
move an overflowing dialog horizontally than vertically (because the title bar 
is at the top).

I also turned the background of the preview to black as it looked odd without 
any background when using this new layout.


Diffs
-----

  
trunk/KDE/kdenetwork/kopete/kopete/config/avdevice/avdeviceconfig_videodevice.ui
 1166377 

Diff: http://reviewboard.kde.org/r/5159/diff


Testing
-------

Tested with and without webcam support.


Screenshots
-----------

The new layout
  http://reviewboard.kde.org/r/5159/s/489/


Thanks,

Aurélien

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to