----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4357/ -----------------------------------------------------------
(Updated 2010-07-04 08:02:15.893737) Review request for Kopete. Changes ------- Updated patch (it is to current trunk now). Also removed "q3signal" dependency, changed it to QMetaObject::invokeMethod. Tested: compiling and translation ru<->de (works for me) Summary ------- This patch makes translator plugin for kopete work again; it adds support for different language lists for different services; it adds up-to-date info about languages and supported translations (for google and for babelfish); it also ports KCM of this plugin to KConfigXT. What must be default behaviour when we cannot translate message? I think we mustn't send it anyway (it was the default behaviour) This addresses bugs 164870, 167503, 168026, 213133, 230686, and 234225. https://bugs.kde.org/show_bug.cgi?id=164870 https://bugs.kde.org/show_bug.cgi?id=167503 https://bugs.kde.org/show_bug.cgi?id=168026 https://bugs.kde.org/show_bug.cgi?id=213133 https://bugs.kde.org/show_bug.cgi?id=230686 https://bugs.kde.org/show_bug.cgi?id=234225 Diffs (updated) ----- /trunk/KDE/kdenetwork/kopete/plugins/translator/CMakeLists.txt 1145775 /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorconfig.kcfg PRE-CREATION /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorconfig.kcfgc PRE-CREATION /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorlanguages.h 1145775 /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorlanguages.cpp 1145775 /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorplugin.h 1145775 /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorplugin.cpp 1145775 /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorpreferences.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp 1145775 /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorprefsbase.ui 1145775 Diff: http://reviewboard.kde.org/r/4357/diff Testing ------- Tested translations en_ru, ru_en, en_es and some others for both babelfish and google services; tested changing services (menu entry must update then); tested incoming and outgoing message translations (with different options) Thanks, Igor
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel