> On 2010-06-25 15:25:40, Raphael Kubo da Costa wrote: > > As I always say, I don't really know this code, but the patch looks good > > overall, aside from some trailing whitespace in some lines and some changes > > to the ui file that aren't necessary. The way the translation options are > > added looks too hardcoded, maybe it'd be good to work on a patch to make > > that more flexible? > > > > Oh, and please wait until trunk is unfrozen to commit.
Thanks for your reply. I think you're right about hardcoding, but I don't know how to make it more flexible. As I can see changes in languages and translation schemes are not so often in this services (google translate and babelfish), so maybe hardcoding this values is not so bad. I'll think about it. And I haven't KDE subversion account (I'm just a volunteer :) ), so it would be great if someone of Kopete developers will commit this patch (after trunk unfreeze, of course). - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4357/#review6288 ----------------------------------------------------------- On 2010-06-25 22:23:52, Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4357/ > ----------------------------------------------------------- > > (Updated 2010-06-25 22:23:52) > > > Review request for Kopete. > > > Summary > ------- > > This patch makes translator plugin for kopete work again; it adds support for > different language lists for different services; it adds up-to-date info > about languages and supported translations (for google and for babelfish); it > also ports KCM of this plugin to KConfigXT. > > What must be default behaviour when we cannot translate message? I think we > mustn't send it anyway (it was the default behaviour) > > > This addresses bugs 164870, 167503, 168026, 213133, 230686, and 234225. > https://bugs.kde.org/show_bug.cgi?id=164870 > https://bugs.kde.org/show_bug.cgi?id=167503 > https://bugs.kde.org/show_bug.cgi?id=168026 > https://bugs.kde.org/show_bug.cgi?id=213133 > https://bugs.kde.org/show_bug.cgi?id=230686 > https://bugs.kde.org/show_bug.cgi?id=234225 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/translator/CMakeLists.txt 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorconfig.kcfg > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorconfig.kcfgc > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatordialog.cpp > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorlanguages.h > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorlanguages.cpp > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorplugin.h 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorplugin.cpp > 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorpreferences.h > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorpreferences.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorprefs.cpp 1142865 > /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorprefsbase.ui > 1142865 > > Diff: http://reviewboard.kde.org/r/4357/diff > > > Testing > ------- > > Tested translations en_ru, ru_en, en_es and some others for both babelfish > and google services; tested changing services (menu entry must update then); > tested incoming and outgoing message translations (with different options) > > > Thanks, > > Igor > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
