-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4274/#review6092
-----------------------------------------------------------

Ship it!


Looks ok for me.

- Olivier


On 2010-06-11 10:17:58, Ralf Haferkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4274/
> -----------------------------------------------------------
> 
> (Updated 2010-06-11 10:17:58)
> 
> 
> Review request for Kopete and Olivier Goffart.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to adjust the priority of a jabber resource when 
> going to an "away" state. This can be used to "redirect" messages to a 
> different resource (e.g an IM client on a mobile device) base on the presence 
> state of kopete.
> 
> 
> This addresses bug 97998.
>     https://bugs.kde.org/show_bug.cgi?id=97998
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1136955 
>   
> /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui
>  1136955 
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.h 
> 1136955 
>   
> /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp 
> 1136955 
> 
> Diff: http://reviewboard.kde.org/r/4274/diff
> 
> 
> Testing
> -------
> 
> Tested with current trunk:
> 
> 1. Configure a priority for the away state in the account settings, lower 
> than the "normal" priority.
> 2. Go online with kopete and another IM client (which has configured a 
> priority less the kopetes "normal priority" bug higher than the "away 
> priority"
> 3. Set the state to "away" in kopete.
> 4. Sent an IM to the account. Watch it arrive on the other client.
> 
> 
> Thanks,
> 
> Ralf
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to