----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4274/#review6080 -----------------------------------------------------------
The patch looks quite cluttered because of the automatic changes to the XML done by Designer: can you post a new version containing only your changes to the XML file? Other than that, as I usually say, I don't know the code -- if it works, we can ship it after trunk is open for feature commits again (ie it will make it for SC 4.6). Do you know if there's any bug report requesting this feature? trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp <http://reviewboard.kde.org/r/4274/#comment5682> Very minor nitpick: ( toggled() ) trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp <http://reviewboard.kde.org/r/4274/#comment5683> Very minor nitpick: extra empty line. - Raphael On 2010-06-10 14:05:46, Ralf Haferkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4274/ > ----------------------------------------------------------- > > (Updated 2010-06-10 14:05:46) > > > Review request for Kopete and Olivier Goffart. > > > Summary > ------- > > This patch adds the ability to adjust the priority of a jabber resource when > going to an "away" state. This can be used to "redirect" messages to a > different resource (e.g an IM client on a mobile device) base on the presence > state of kopete. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1136354 > > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui > 1136354 > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.h > 1136354 > trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp > 1136354 > > Diff: http://reviewboard.kde.org/r/4274/diff > > > Testing > ------- > > Tested with current trunk: > > 1. Configure a priority for the away state in the account settings, lower > than the "normal" priority. > 2. Go online with kopete and another IM client (which has configured a > priority less the kopetes "normal priority" bug higher than the "away > priority" > 3. Set the state to "away" in kopete. > 4. Sent an IM to the account. Watch it arrive on the other client. > > > Thanks, > > Ralf > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
