----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3074/#review4405 -----------------------------------------------------------
Ship it! I like this. It's a cleaner version of disabling video support for Win32 that has even more uses than that did. Please commit (and be sure to close the review request when this is committed) - Matt On 2010-03-04 18:43:27, Frank Schaefer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3074/ > ----------------------------------------------------------- > > (Updated 2010-03-04 18:43:27) > > > Review request for Kopete. > > > Summary > ------- > > Add option to build Kopete without video-support. Default value is > "off"="build with video-support". > > > Maybe we should simplify these > > #if !defined(Q_OS_WIN) && !defined(VIDEOSUPPORT_DISABLED) > > lines in the protocol code to > > #ifndef VIDEOSUPPORT_DISABLED > > and let cmake control compilation. These parts of the code actually compile > on Windows, too (but of course it doesn't make sense there). > This would also make it easier for us to enable the video-code of the > protocols in the future, when - for example - support for the > Windows-video-API is added to class videodevice. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/kopete/config/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/libkopete/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/libkopete/ui/avatarselectorwidget.cpp 1093638 > /trunk/KDE/kdenetwork/kopete/libkopete/ui/avatarwebcamdialog.cpp 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/bonjour/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/qq/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/qq/ui/qqwebcamdialog.cpp 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/testbed/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/testbed/ui/testbedwebcamdialog.cpp > 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahoowebcam.cpp 1093638 > > Diff: http://reviewboard.kde.org/r/3074/diff > > > Testing > ------- > > > Thanks, > > Frank > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
