> On 2010-03-03 18:31:29, Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt, line 9 > > <http://reviewboard.kde.org/r/3074/diff/2/?file=20300#file20300line9> > > > > TRUE for consistency?
For consistency it should be ON ;) I will change it. > On 2010-03-03 18:31:29, Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/libkopete/CMakeLists.txt, line 150 > > <http://reviewboard.kde.org/r/3074/diff/2/?file=20302#file20302line150> > > > > Would be nice to remove the trailing whitespace here and in the other > > places. Sure. > On 2010-03-03 18:31:29, Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt, line 11 > > <http://reviewboard.kde.org/r/3074/diff/2/?file=20300#file20300line11> > > > > Are you sure there's no problem with making the option exist only in > > some platforms? It works fine. You can test for example by putting a "NOT" before the WIN32 in this if-section. Then cmake-gui doesn't show it as an option, too. > On 2010-03-03 18:31:29, Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/libkopete/ui/avatarselectorwidget.cpp, line 119 > > <http://reviewboard.kde.org/r/3074/diff/2/?file=20303#file20303line119> > > > > Should this line and the one below be updated to reflect the current > > state? I think you are right. Q_OS_WIN is not used anymore and it doesn't matter WHY the video-support is enabled or disabled. - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3074/#review4349 ----------------------------------------------------------- On 2010-03-03 17:06:43, Frank Schaefer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3074/ > ----------------------------------------------------------- > > (Updated 2010-03-03 17:06:43) > > > Review request for Kopete. > > > Summary > ------- > > Add option to build Kopete without video-support. Default value is > "off"="build with video-support". > > > Maybe we should simplify these > > #if !defined(Q_OS_WIN) && !defined(VIDEOSUPPORT_DISABLED) > > lines in the protocol code to > > #ifndef VIDEOSUPPORT_DISABLED > > and let cmake control compilation. These parts of the code actually compile > on Windows, too (but of course it doesn't make sense there). > This would also make it easier for us to enable the video-code of the > protocols in the future, when - for example - support for the > Windows-video-API is added to class videodevice. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/kopete/config/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/libkopete/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/libkopete/ui/avatarselectorwidget.cpp 1093638 > /trunk/KDE/kdenetwork/kopete/libkopete/ui/avatarwebcamdialog.cpp 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/bonjour/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/qq/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/qq/ui/qqwebcamdialog.cpp 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/testbed/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/testbed/ui/testbedwebcamdialog.cpp > 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/CMakeLists.txt 1093638 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahoowebcam.cpp 1093638 > > Diff: http://reviewboard.kde.org/r/3074/diff > > > Testing > ------- > > > Thanks, > > Frank > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
