On Tue, Feb 2, 2010 at 1:00 AM, Frank Schaefer <fschaefer....@googlemail.com > wrote:
> Raphael Kubo da Costa schrieb: > >> No, the behavior should depend on the platform / OS: > >> - Windows: no libv4l available > >> => do not search for it > >> => do not log anything > >> - Linux: libv4l is mandatory > >> => use FIND_PACKAGE(LibV4L2 REQUIRED) > >> => logs the result, critical error if package is missing (before > >> build start) > >> - others: libv4l is optional > >> => use macro_optional_find_package(LibV4L2) > >> => use macro_log_feature to log the result in the "option packages" > >> section > >> > > > > What I suggested is something like the following: > > > > if (NOT WIN32) > > set (LIBV4L2_REQUIRED FALSE) > > if (CMAKE_SYSTEM_NAME STREQUAL Linux) > > set (LIBV4L2_REQUIRED TRUE) > > endif (CMAKE_SYSTEM_NAME STREQUAL Linux) > > > > find_package(LibV4L2) > > macro_log_feature(LIBV4L2_FOUND "libv4l2" "Collection of video4linux > support > > libraries" LIBV4L2_REQUIRED "" "Required for better webcam support") > > endif (NOT WIN32) > > macro_bool_to_01(LIBV4L2_FOUND HAVE_LIBV4L2) > > > > I haven't tested it, but something along these lines should do what we > both > > want. > > > > > Yes, that should work with the module-modifications you already have > commited, thanks. I will test it tomorrow. > Is it a good idea to make it compulsory? I tried building kdenetwork today and it failed, because of the required dependency libv4l2. I dont have a webcam and i dont see a reason why i should install libv4l2. I assume there are many other users as well who probably may not have webcam as well. I am not against it, but I think, it better should be optional rather than compulsory, what are you views ? ----------------------------------------------------------------------------- -- The following REQUIRED packages could NOT be located on your system. -- You must install these packages before continuing. ----------------------------------------------------------------------------- * libv4l2 <http://hansdegoede.livejournal.com> Collection of video4linux support libraries Required for better webcam support ----------------------------------------------------------------------------- CMake Error at /home/roide/kde/share/apps/cmake/modules/MacroLogFeature.cmake:141 (MESSAGE): Exiting: Missing Requirements Call Stack (most recent call first): CMakeLists.txt:98 (macro_display_feature_log) CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: BTCORE_INCLUDE_DIR used as include directory in directory /home/roide/kde/src/trunk/KDE/kdenetwork/kget/transfer-plugins/bittorrent -- Configuring incomplete, errors occurred! make: *** No targets specified and no makefile found. Stop. -- Greetings, KDE Developer irc nick - roide roideuniverse dot blogspot dot com twitter dot com/roideuniverse --There is no shortcut to Success!
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
