Raphael Kubo da Costa schrieb:
>> No, the behavior should depend on the platform / OS:
>> - Windows:   no libv4l available
>>    => do not search for it
>>    => do not log anything
>> - Linux:   libv4l is mandatory
>>    => use FIND_PACKAGE(LibV4L2 REQUIRED)
>>    => logs the result, critical error if package is missing (before
>> build start)
>> - others:    libv4l is optional
>>    => use macro_optional_find_package(LibV4L2)
>>    => use macro_log_feature to log the result in the "option packages"
>> section
>>     
>
> What I suggested is something like the following:
>
> if (NOT WIN32)
>   set (LIBV4L2_REQUIRED FALSE)
>   if (CMAKE_SYSTEM_NAME STREQUAL Linux)
>     set (LIBV4L2_REQUIRED TRUE)
>   endif (CMAKE_SYSTEM_NAME STREQUAL Linux)
>
>   find_package(LibV4L2)
>   macro_log_feature(LIBV4L2_FOUND "libv4l2" "Collection of video4linux 
> support 
> libraries" LIBV4L2_REQUIRED "" "Required for better webcam support")
> endif (NOT WIN32)
> macro_bool_to_01(LIBV4L2_FOUND HAVE_LIBV4L2)
>
> I haven't tested it, but something along these lines should do what we both 
> want.
>
>   
Yes, that should work with the module-modifications you already have
commited, thanks. I will test it tomorrow.
Would be nice to see the other modules beeing rewritten this way, too...;)

Cheers,
Frank
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to