----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2449/ -----------------------------------------------------------
Review request for Kopete and Roman Jarosz. Summary ------- Today I got really pissed off when I've received the ICQ "You have been added" spam for the 4th time in 3 hours, so I've added filtering capabilities to InfoEventManager. This patch adds eventAboutToBeAdded signal to InfoEventManager, this signal could/should be used to filter incoming InfoEvent. I know we are in feature freeze but this is a small change which won't break anything and we will be able to make filtering plugin(s) without patching Kopete. I've also update Kopete Privacy Plugin and will post the patch right after this one, but the second patch can't go to SVN because of the freeze. Diffs ----- /trunk/KDE/kdenetwork/kopete/libkopete/kopeteinfoevent.h 1065804 /trunk/KDE/kdenetwork/kopete/libkopete/kopeteinfoevent.cpp 1065804 /trunk/KDE/kdenetwork/kopete/libkopete/kopeteinfoeventmanager.h 1065804 /trunk/KDE/kdenetwork/kopete/libkopete/kopeteinfoeventmanager.cpp 1065804 Diff: http://reviewboard.kde.org/r/2449/diff Testing ------- Done Thanks, Roman _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel