> On 2009-10-19 12:48:58, Detlev Casanova wrote: > > I don't think that GMail will be upgraded to the Jingle standard soon so, > > you ship it ! :-) > > Pali Rohár wrote: > For support with gmail plugin I must change some code in google > libjignle. Trunk version in http://libjingle.googlecode.com/svn/trunk/ is for > old gcc and old libraries. This libjingle code works fine only if I applyed > patch from http://code.google.com/p/libjingle/issues/list . > > So If I can commit this patch for google talk voice support (which use > external executables), can I import google libjingle from > http://libjingle.googlecode.com/svn/trunk/ rev. 7 to kopete/jabber kde > repository with patches? With am2cmake I convert autoconf/automake to cmake > and now I can compile libjingle executables with kopete. > > Pali Rohár wrote: > Can I commit this patch now? > > Rafa? Mi?ecki wrote: > Detlev Casanova: you mailed me with link to > svn://anonsvn.kde.org/home/kde/branches/work/kopete/new_jingle on > kopete-devel. AFAIU this is going to be really used Jingle implementation in > Kopete soon. > > Doesn't that mean duplicated code? I mean potential Kopete's Jingle > implementation and what this patch adds. Maybe it would be better to get > svn://anonsvn.kde.org/home/kde/branches/work/kopete/new_jingle merged > mainline and then hack Kopete's implementation to work with Google's > modification of Jingle standard?
No, and for 2 reasons : First, new_jingle would need lots of work and is not compliant at all with Google Jingle Secondly, Google will update their service to actual Jingle but it will have to wait a little longer and it won't be available before KDE 4.4 is released (or at least, hard freezed). So for KDE 4.4, let's have a Google Jingle implementation and, maybe, an actual Jingle implementation to be compatible with both implementation and for KDE 4.5, it will be OK to remove libjingle. - Detlev ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review2712 ----------------------------------------------------------- On 2009-10-25 13:35:31, Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/753/ > ----------------------------------------------------------- > > (Updated 2009-10-25 13:35:31) > > > Review request for Kopete and Detlev Casanova. > > > Summary > ------- > > This patch add support (for jabber protocol) Google Talk libjingle voice > call. It use external libjingle "call" applicaion and stun server from > http://code.google.com/p/libjingle/ > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1040003 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp > PRE-CREATION > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h > PRE-CREATION > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp > PRE-CREATION > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1040003 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1040003 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1040003 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1040003 > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui > 1040003 > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp > 1040003 > > Diff: http://reviewboard.kde.org/r/753/diff > > > Testing > ------- > > It works fine with call application from http://code.google.com/p/libjingle/ > with patches from http://code.google.com/p/libjingle/issues/list installed in > PATH > > I try it with windows version of Google Talk (on windows) and voice call > works. I can make call, accept/reject incoming call, hang up call. > > I try it with windows gmail voice/video plugin and voice call works fine. > > > Thanks, > > Pali > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
