----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1186 -----------------------------------------------------------
General note about addition of new strings: currently we are in both feature and string freeze, so you have to ask to the translators mailing list (kde-i18n-...@kde.org) the permission for adding this new string (that is related to a new feature). /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt <http://reviewboard.kde.org/r/753/#comment744> Add a TODO about adding a cmake check (in the perspective of getting rid of the imported code). /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h <http://reviewboard.kde.org/r/753/#comment751> Usual const QString& needed (like in the whole file). /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h <http://reviewboard.kde.org/r/753/#comment752> Like above: usually class members are named like "m_foo", "foo_" or "_foo". Also, some slightly more meaningful name would be nice. /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h <http://reviewboard.kde.org/r/753/#comment753> No need for QString& in signals, just use const QString& /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp <http://reviewboard.kde.org/r/753/#comment754> qDebug() is debug output which cannot be disabled from KDE configuration. Either use kDebug() with some kopete/jabber debug area, or #ifdef GOOGLETALK_DEBUG all of them. /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp <http://reviewboard.kde.org/r/753/#comment755> Looks like a i18n() string is missing? /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp <http://reviewboard.kde.org/r/753/#comment756> Another missing i18n()? /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h <http://reviewboard.kde.org/r/753/#comment745> No need to #ifdef a class forward declaration, it can stay even w/o GOOGLETALK_SUPPORT. /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h <http://reviewboard.kde.org/r/753/#comment746> Here (and in many other places) there are whitespace-only changes. Could you avoid them, please? /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h <http://reviewboard.kde.org/r/753/#comment747> Should take a const QString&, and be a const function. /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h <http://reviewboard.kde.org/r/753/#comment748> Should take a const QString& /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h <http://reviewboard.kde.org/r/753/#comment749> 'g' is not that meaningful, especially as it is a class member. What about calling it 'm_googleTalk'? /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp <http://reviewboard.kde.org/r/753/#comment750> This adds a new i18n string. - Pino On 2009-05-23 02:33:43, Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/753/ > ----------------------------------------------------------- > > (Updated 2009-05-23 02:33:43) > > > Review request for Kopete. > > > Summary > ------- > > This patch add support (for jabber protocol) Google Talk libjingle voice > call. It use external libjingle "call" applicaion and stun server from > http://code.google.com/p/libjingle/ > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 971715 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp > PRE-CREATION > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h > PRE-CREATION > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp > PRE-CREATION > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 971715 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 971715 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 971715 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 971715 > > Diff: http://reviewboard.kde.org/r/753/diff > > > Testing > ------- > > It works fine with call application from http://code.google.com/p/libjingle/ > with patches from http://code.google.com/p/libjingle/issues/list installed in > PATH > > I try it with windows version of Google Talk (on windows) and voice call > works. I can make call, accept/reject incoming call, hang up call. > > > Thanks, > > Pali > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
