> On 2009-10-17 02:50:31, Matt Rogers wrote: > > no action to address reviews, marked the review as discarded. Please feel > > free to resurrect it when there are updates available for the patch.
ugh, didn't see that one, I'll post an update soon. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2680 ----------------------------------------------------------- On 2009-09-12 14:33:25, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-09-12 14:33:25) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat > window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable > format (bigger than in the chat view) and the participants list view looked > kind of boring/empty most of the time, so I came up with this patch that adds > a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the > screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h 1022530 > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp > 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp > 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h > PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
