----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2153 -----------------------------------------------------------
I haven't seen the code yet, but here are some thoughts. Looking at the screenshot, it seems to me that the image is kinda lost in the contest. Instead of that, it would probably be a better idea (if seeing the big picture is really desired) to arrange items in icon mode instead of item mode, and then set a bigger icon size to them. Wouldn't it be enough if we just had a tooltip showing all the info including the contact icon? - Gustavo On 2009-08-24 18:56:35, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-08-24 18:56:35) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat > window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable > format (bigger than in the chat view) and the participants list view looked > kind of boring/empty most of the time, so I came up with this patch that adds > a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the > screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp > 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h > PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
